UHF-10176 unify recommendations between translations #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recommendations based on one language instead of having separate recommendations for all translations
…unable handle translations. Must get translations manually
…ow on the block itself maybe
…langcodes into account directly. Fixed the order by in the query.
hyrsky
approved these changes
Jun 13, 2024
…y doesn't have proper content for the expected language
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-10176
Allow showing same recommendations for all translations if possible
What was done
Using target_langcode allows showing the main language's recommendations for all translations if possible.
How to install
git checkout UHF-10176make freshmake drush-crHow to test
The Original testing instructions apply.
Continuous documentation