Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X: Change Pinnalla juuri nyt to only say Pinnalla in Finnish #638

Merged
merged 2 commits into from
Jun 6, 2024
Merged

UHF-X: Change Pinnalla juuri nyt to only say Pinnalla in Finnish #638

merged 2 commits into from
Jun 6, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jun 6, 2024 •
edited
Loading

UHF-X

What was done

  • Change Pinnalla juuri nyt to only say Pinnalla in Finnish.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-X_translation_change
  • Run make drush-cim drush-cr drush-locale-update drush-cr

How to test

  • Check that the front page block Pinnalla juuri nyt has just Pinnalla as the title in Finnish. Check also that the paragraph is called Pinnalla in the editor interface as well.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

khalima
khalima approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be important change for someone. Obviously, I'm not that someone. 😶‍🌫️

@teroelonen teroelonen merged commit cf9c9ce into dev Jun 6, 2024
2 checks passed
@teroelonen teroelonen deleted the UHF-X_translation_change branch June 6, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima