Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9823: Fix the updating news table of contents #632

Merged
merged 2 commits into from
May 30, 2024
Merged

UHF-9823: Fix the updating news table of contents #632

merged 2 commits into from
May 30, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented May 30, 2024 •
edited by jira bot
Loading

UHF-9823

What was done

  • Fix class to correct one in updating news table of contents so that unwanted titles are ignored

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9823_updating_news_toc_bug_fix
  • Run make drush-cr

How to test

  • Check that table of contents on updating news no longer includes h2 elements from inside text paragraphs.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

khalima
khalima approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! 🚀

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@teroelonen teroelonen merged commit 02962b1 into dev May 30, 2024
2 checks passed
@teroelonen teroelonen deleted the UHF-9823_updating_news_toc_bug_fix branch May 30, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima