Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9915: Main news and main articles block changes #622

Merged
merged 15 commits into from
May 29, 2024
Merged

UHF-9915: Main news and main articles block changes #622

merged 15 commits into from
May 29, 2024

Conversation

j-mys
Copy link
Contributor

@j-mys j-mys commented May 22, 2024 •
edited by jira bot
Loading

UHF-9915

What was done

Frontpage layout changes

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9915
    • drush cim
    • make fresh
  • Run make drush-cr

How to test

Compare frontpage to design

  • Check that this feature works
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

@teroelonen teroelonen changed the base branch from dev to UHF-9736 May 22, 2024 10:10
teroelonen
teroelonen requested changes May 22, 2024
View reviewed changes
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_main-news-articles.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_main-news-articles.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_main-news-articles.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_main-news-articles.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_main-news-articles.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_main-news-articles.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_index.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/templates/paragraph/paragraph--front-page-top-news.html.twig Outdated Show resolved Hide resolved
@teroelonen teroelonen changed the title Uhf 9915 UHF-9915: Main news and main articles block changes May 22, 2024
teroelonen
teroelonen requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the styles. They are not quite 100% yet and there was some coding standard issues on the styles. Commented on the coding standard issues. After they are fixed the layout improvement can begin.

public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_top-news.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_top-news.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_top-news.scss Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_top-news.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_top-news.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_top-news.scss Outdated Show resolved Hide resolved
public/themes/custom/hdbt_subtheme/src/scss/06_components/paragraphs/_top-news.scss Outdated Show resolved Hide resolved
@j-mys j-mys marked this pull request as ready for review May 27, 2024 10:12
@j-mys j-mys mentioned this pull request May 27, 2024
Merged
teroelonen
teroelonen approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go now from my side 🦖

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@teroelonen teroelonen merged commit 0c6c776 into UHF-9736 May 29, 2024
2 checks passed
@teroelonen teroelonen deleted the UHF-9915 branch May 29, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-mys @teroelonen