Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9739 Updating news #608

Merged
merged 15 commits into from
May 20, 2024
Merged

UHF-9739 Updating news #608

merged 15 commits into from
May 20, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented May 7, 2024

UHF-9739

What was done

  • Added updating news section for the news content-type.

How to install

  • Checkout latest dev branch and setup the front page instance with it.
    • git checkout dev
    • make fresh
  • Checkout this feature branch.
    • git checkout UHF-9739
  • Require the hdbt, hdbt-admin and helfi_platform_config branches as well.
    • make shell
    • composer require drupal/hdbt:dev-UHF-9739 && composer require drupal/hdbt_admin:dev-UHF-9739 && composer require drupal/helfi_platform_config:dev-UHF-9739
  • Run make drush-cim drush-cr drush-updb
  • Run make drush-locale-update drush-cr to import translations. This could take a while since front page has a lot of languages enabled.
  • Run make drush-uli and follow the link.

How to test

  • Go to edit any news item. You should see a new field called "Updating news" that should be closed as it doesn't have anything written inside it.
  • Open it and add new updating news item. The fields should contain title, time and the actual content with text paragraph preselected and option to add more text, image, remote video and banner paragraphs. The title and time should be marked as compulsory. Fill some information and create one more updating news item and fill the fields for that one as well. Save the node and view the node.
  • There should now be "Latest news" block that lists the two updating news items that you just added under the main content (in the real world scenario the news items main body will be emptied and moved as the first updating news item by the editor but the layout shouldn't break even if it is left untouched). They should be in reverse order so that the first listed item is the one you wrote last. The table of contents for the news updates should work as links to the updating news items.
  • Make sure the layout looks similar to what is designed here: https://www.figma.com/file/v5YC5vwdlXr1N8RaZ9SMPO/Hel.fi-Ajankohtaissis%C3%A4ll%C3%B6t-(Uutiset)?type=design&node-id=988%3A41005&mode=design&t=GSjDNh8nslGEaODl-1
  • Check that code follows our standards
  • Check the other PRs code as well.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@khalima khalima marked this pull request as ready for review May 17, 2024 09:48
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@khalima khalima changed the base branch from dev to update-configuration May 20, 2024 09:49
@github-actions github-actions bot force-pushed the update-configuration branch from 312cd39 to 34de314 Compare May 20, 2024 09:49
@khalima khalima merged commit 59da9bc into update-configuration May 20, 2024
2 checks passed
@khalima khalima deleted the UHF-9739 branch May 20, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants