Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X: Make the global announcement check box visible on the node form #443

Merged
merged 1 commit into from
Sep 26, 2023
Merged

UHF-X: Make the global announcement check box visible on the node form #443

merged 1 commit into from
Sep 26, 2023

Conversation

teroelonen
Copy link
Contributor

UHF-X

What was done

  • On front page the checkbox that enables you to add a global announcement has been hidden for some reason. Making it visible again.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-X_make_global_announcement_checkbox_visible
    • make fresh
  • Run make drush-cr drush-cim drush-cr

How to test

  • Check that you are able to see the Publish externally checkbox on announce edit/create form.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juho-lehmonen juho-lehmonen self-requested a review September 26, 2023 13:02
@teroelonen teroelonen merged commit e3358f9 into dev Sep 26, 2023
@teroelonen teroelonen deleted the UHF-X_make_global_announcement_checkbox_visible branch September 26, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juho-lehmonen juho-lehmonen juho-lehmonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @juho-lehmonen