Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8516 news lander sitemap #428

Merged
merged 3 commits into from
Sep 6, 2023
Merged

UHF-8516 news lander sitemap #428

merged 3 commits into from
Sep 6, 2023

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Sep 1, 2023

UHF-8516

What was done

  • Added etusivu sitemap to sitemap index
  • Added news landing pages to sitemap (/uutiset, /news, /nyheter)

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-8516_news_lander_sitemap
    • make fresh
  • Run make drush-cr

How to test

  • Run drush cr
  • Run drush ssg
  • Go to https://helfi-etusivu.docker.so/sitemap.xml (sitemap index)
    • Link to etusivu production sitemap should be set.
  • Go to /fi/sitemap.xml
    • search for the news landing pages ('/fi//uutiset ', '/en/news ', '/sv/nyheter ')

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

links:
-
path: /
priority: '1.0'
changefreq: daily
-
path: /uutiset
Copy link
Contributor

@hyrsky hyrsky Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives warning

[warning] The custom path /uutiset has been omitted from the XML sitemaps as it does not exist. You can review custom paths <a href="https://helfi-etusivu.docker.so/en/admin/config/search/simplesitemap/custom">here</a>.

when run using drush ssg command. The sitemap is still correct, since simple_sitemap gets all language versions from /news. Also, when sitemap generation is started from /fi/admin/config/search/simplesitemap, there is no warning. Therefore, it is best to have /uutiset here as well.

@rpnykanen rpnykanen merged commit d2f25c8 into dev Sep 6, 2023
@rpnykanen rpnykanen deleted the UHF-8516_news_lander_sitemap branch September 6, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants