Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8590: Search accessibility fix #409

Closed
wants to merge 3 commits into from
Closed

UHF-8590: Search accessibility fix #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca4bf05
Fix label field precise
xkhaven Jul 12, 2023
d319630
Fixed aria-hidden
xkhaven Jul 12, 2023
e4d5ee1
JS rebuild
xkhaven Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ..._news_archive/assets/main.dad213d3.js.map → ..._news_archive/assets/main.852895e2.js.map
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions public/modules/custom/helfi_news_archive/assets/main.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion public/modules/custom/helfi_news_archive/js/src/components/form/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ export const Dropdown = ({
placeholder,
searchState,
setQuery,
clearButtonAriaLabel = Drupal.t('Clear selection', {}, { context: 'News archive clear button aria label' }),
clearButtonAriaLabel = Drupal.t(
'Clear @label selection',
{ '@label': label },
{ context: 'News archive clear selection label' }
),
selectedItemRemoveButtonAriaLabel = Drupal.t('Remove item', {}, { context: 'News archive remove item aria label' }),
toggleButtonAriaLabel = Drupal.t('Open the combobox', {}, { context: 'News archive open dropdown aria label' }),
}: DropdownProps) => {
Expand Down
2 changes: 1 addition & 1 deletion public/modules/custom/helfi_news_archive/js/src/containers/SelectionsContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const SelectionsContainer = ({ clearSelection, searchState, setSearchState }: Se
{filters}
<li className='news-form__clear-all'>
<Button
aria-hidden={filters.length ? 'true' : 'false'}
aria-hidden={filters.length ? 'false' : 'true'}
className='news-form__clear-all-button'
iconLeft={<IconCross className='news-form__clear-all-icon' />}
onClick={clearSelections}
Expand Down
4 changes: 4 additions & 0 deletions public/modules/custom/helfi_news_archive/translations/fi.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ msgctxt "News archive clear selections"
msgid "Clear selections"
msgstr "Tyhjennä valinnat"

msgctxt "News archive clear selection label"
msgid "Clear @label selection"
msgstr "Tyhjennä @label valinnat"

msgctxt "News archive no results"
msgid "No results found"
msgstr "Ei tuloksia"
Expand Down
4 changes: 4 additions & 0 deletions public/modules/custom/helfi_news_archive/translations/sv.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ msgctxt "News archive clear button aria label"
msgid "Clear selection"
msgstr "Rensa alla"

msgctxt "News archive clear selection label"
msgid "Clear @label selection"
msgstr "Rensa alla @label"

msgctxt "News archive remove item aria label"
msgid "Remove item"
msgstr "Töm valda"
Expand Down