Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-1781: Remove accidental code for testing #404

Merged
merged 1 commit into from
Jul 3, 2023
Merged

UHF-1781: Remove accidental code for testing #404

merged 1 commit into from
Jul 3, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jul 3, 2023 •
edited by jira bot
Loading

UHF-1781

What was done

  • Removed test-code.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-1781_hero_designs_allowed_values_change
    • make fresh
  • Run make drush-cr

How to test

  • Check that there is no more test design for hero available.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

khalima
khalima approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL 😅

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teroelonen teroelonen merged commit 947c956 into dev Jul 3, 2023
@teroelonen teroelonen deleted the UHF-1781_hero_designs_allowed_values_change branch July 3, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima