Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9214 Visual regression tests for Events list paragraph #995

Merged
merged 7 commits into from
May 29, 2024
Merged

Conversation

khalima
Copy link
Contributor

@khalima khalima commented May 28, 2024

UHF-9214

What was done

  • Added fixtures to a variable for the JS.
  • Use Event list paragraph in visual regression tests.
  • Use the data from fixtures if the 'use_fixtures' variable is set.

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/995/html_report/

@khalima
Copy link
Contributor Author

khalima commented May 28, 2024

The CI Test will fail until the City-of-Helsinki/drupal-helfi-platform-config#767 PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recreate-reference-images Use this label to re-create reference images used by Visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants