Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9911: React errors resolving #970

Merged
merged 3 commits into from
Apr 22, 2024
Merged

UHF-9911: React errors resolving #970

merged 3 commits into from
Apr 22, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Apr 19, 2024

UHF-9911

What was done

  • Fix errors on form container not having onChange for hidden selects, removing selected attribute from options

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9911
  • Run make drush-cr

How to test

  • Go to https://helfi-rekry.docker.so/fi/avoimet-tyopaikat and open inspector.
  • Loading the page and selecting some options from the drop down shouldn't cause anymore errors on console like it did before.
  • Check the code for the webpack. The feature itself can be tested only on production so there is no way to check this on local.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

@teroelonen teroelonen marked this pull request as ready for review April 22, 2024 06:59
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/970/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants