Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X fix 666666 color #940

Merged
merged 2 commits into from
Apr 5, 2024
Merged

UHF-X fix 666666 color #940

merged 2 commits into from
Apr 5, 2024

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Apr 5, 2024

UHF-X

Color #666666 was changed to #595959 earlier, still some remaining spots with old color could be found.
One of the old colors can be seen on this address text.
image

What was done

  • Switched to use fixed color instead of the HDS css variable with old color.

How to install

  • Make sure your SOTE instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_fix_666666_color
  • Run make drush-cr

How to test

  • Open this page in your local environment. Check that the color of the address text is now #595959
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Copy link

github-actions bot commented Apr 5, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/940/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as it should 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants