Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9569: servicemap api changes #929

Merged
merged 2 commits into from
Mar 22, 2024
Merged

UHF-9569: servicemap api changes #929

merged 2 commits into from
Mar 22, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Mar 22, 2024 •
edited by teroelonen
Loading

UHF-9569

What was done

  • Fix deprecated usage of servicemap api.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9569-servicemap-api-changes
  • Run make drush-cr

How to test

hyrsky added 2 commits March 22, 2024 09:02
@hyrsky
UHF-9569: UHF-9569: Fix deprecated usage of administrative_division e…
6b50d31 
…ndpoint

service_point_id- and unit-fields will be removed in the future. They
should be replaced with the use of "units" field. The deprecated fields
will stop appearing in the api results some time soon.
@hyrsky
UHF-9569: UHF-9569: Compile assets
a323248
@hyrsky hyrsky force-pushed the UHF-9569-servicemap-api-changes branch from 5af5351 to a323248 Compare March 22, 2024 07:04
teroelonen
teroelonen approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🦖

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/929/html_report/

@hyrsky hyrsky merged commit f97480a into main Mar 22, 2024
2 checks passed
@hyrsky hyrsky deleted the UHF-9569-servicemap-api-changes branch March 22, 2024 11:27
This was referenced Mar 22, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyrsky @teroelonen