Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8908: Convert email field type to email #928

Merged
merged 2 commits into from
Mar 21, 2024
Merged

UHF-8908: Convert email field type to email #928

merged 2 commits into from
Mar 21, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Mar 21, 2024

UHF-8908

What was done

  • Removed service channel email field processing, adjusted styles accordingly

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the helfi_api_base, helfi_tpr, HDBT theme and helfi_platform_config
    • composer require drupal/helfi_api_base:dev-UHF-8908 drupal/helfi_tpr:dev-UHF-8908 drupal/hdbt:dev-UHF-8908 drupal/helfi_platform_config:dev-UHF-8908 -W
  • Clear cache and go to shell make drush-cr shell
  • Run migrations
    • drush migrate:import tpr_unit --update
    • drush migrate:import tpr_service_channel --update
  • Run database updates
    • drush updb -y

How to test

Designers review

  • This PR does not need designers review

Other PRs

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. 🚀

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/928/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants