UHF-X: Check for list item count before rendering ul #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkkimaagi
force-pushed
the
UHF-X_empty_ul_elements
branch
from
fecf4de to
1eaaeaf
Compare
Arkkimaagi
changed the title
|
|
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-X
Siteimprove found a bunch of pages that have
element without visible content in it. Basically a list with no list-iteims.- This event has missing ul content:
- News, job and plans-and-building-projects filters have similar problem in the filter area:
- Card template was fixed to check for list content before rendering ul elements
- Filter template was fixed to check for list content before rendering ul elements
- Make sure your instance is up and running on latest dev branch.
- Update the HDBT theme
- Run
- Check that events with not tags do not render ul-element for the tags
- Check that filter-forms do not render ul-element for the parameters if there are none
- Check that code follows our standards
- This PR does not need designers review
- This PR has been visually reviewed by a designer (Name of the designer)
What was done
How to install
git pull origin devmake freshcomposer require drupal/hdbt:dev-UHF-X_empty_ul_elementsmake drush-crHow to test
Designers review