Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9497 #909

Merged
merged 12 commits into from
Feb 22, 2024
Merged

UHF-9497 #909

merged 12 commits into from
Feb 22, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Feb 15, 2024

UHF-9497

What was done

  • Removed link button classes from banner and hearings paragraphs.
  • Refactored link-button twig to support new hds-button with data-variables.
  • Moved 'open in new tab' helper text to helfi-link twig and added a check for data-variables in url object attributes.
  • Removed obsolete class from buttons and converted banner to use data-variables.
  • Fixed icon inclusions in banner paragraph.

How to install and test

Check instructions from City-of-Helsinki/drupal-helfi-platform-config#690

  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@khalima khalima marked this pull request as ready for review February 19, 2024 14:23
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues pointed out in Slack but if they are fine the I would say this is good to go 🦖

@teroelonen teroelonen added the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Feb 22, 2024
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/909/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recreate-reference-images Use this label to re-create reference images used by Visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants