Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X Hide rns footer #908

Merged
merged 3 commits into from
Feb 28, 2024
Merged

UHF-X Hide rns footer #908

merged 3 commits into from
Feb 28, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Feb 14, 2024

What was done

  • Prepare to the fact that hiding the rns-footer element doensn't work.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_hide_rns_footer
  • Run make drush-cr

How to test

  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

teroelonen
teroelonen approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🦖

@khalima khalima added the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Feb 28, 2024
@khalima khalima merged commit 13dbc7a into main Feb 28, 2024
1 of 2 checks passed
@khalima khalima deleted the UHF-X_hide_rns_footer branch February 28, 2024 07:06
This was referenced Feb 28, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
recreate-reference-images Use this label to re-create reference images used by Visual regression tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen