Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Fix nested p-tags in tpr-service-teaser description #885

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Jan 18, 2024

UHF-X: Fix nested p-tags in tpr-service-teaser description

Advisory services listing has invalid p > p structure as the card component is called as if the description would not have html formatting.

This causes the browser to create empty p-tags before and after the description content.
image

What was done

  • tpr-service--teaser-search-result.html.twig was modified to tell the card template that the card_description format is indeed html.

How to install

  • Make sure your Strategia instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_advisory_services_teaser_html
  • Run make drush-cr

How to test

  • Check that Neuvontapalvelut no longer produces faulty p-elements.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works nicely 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants