Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-5253: Job search location filter #864

Merged
merged 10 commits into from
Dec 27, 2023
Merged

UHF-5253: Job search location filter #864

merged 10 commits into from
Dec 27, 2023

Conversation

xkhaven
Copy link
Contributor

@xkhaven xkhaven commented Dec 21, 2023 •
edited
Loading

UHF-5253

What was done

  • Added area selection for filtering search result

How to install

  • Make sure your instance is up and running on latest dev branch.
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-5253_Job_location_filter
  • Run make drush-cr drush-locale-update

How to test

Designers review

  • This PR does not need designers review

Other PRs

@xkhaven xkhaven mentioned this pull request Dec 21, 2023
Merged
4 tasks
@xkhaven xkhaven marked this pull request as ready for review December 22, 2023 07:16
Jussiles
Jussiles suggested changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Some thing that should be fixed before the merge.

src/js/react/apps/job-search/enum/PostalCodes.ts Outdated Show resolved Hide resolved
src/js/react/apps/job-search/containers/FormContainer.tsx Outdated Show resolved Hide resolved
src/js/react/apps/job-search/store.tsx Outdated Show resolved Hide resolved
Jussiles
Jussiles approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good now! 🦜

@xkhaven xkhaven merged commit e9882c2 into main Dec 27, 2023
1 check passed
@xkhaven xkhaven deleted the UHF-5253_Job_location_filter branch December 27, 2023 11:06
This was referenced Dec 27, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@j-mys j-mys mentioned this pull request Jan 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jussiles Jussiles Jussiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xkhaven @Jussiles