Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X secondary liftup with image link color #860

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Dec 21, 2023

UHF-X

After CKEditor 5, we no longer have .link class with our user edited links. This caused a link color selector to not apply to secondary colored liftups with image. (which caused problems with themes Tram and Bus, as they have primary link color on the light side due to their dark primary bg color. So check this on Sote)

image

What was done

  • secondary links without .link class were included in the secondary color

How to install

  • Make sure your Sote instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_secondary-liftup-with-image-link-color
  • Run make drush-cr

How to test

  • Check that secondary color liftups with image have proper default link colors.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works and is good to go 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants