Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uhf x ckeditor hiding anchors from word #859

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Dec 21, 2023

UHF-X

Since CKEditor has a bug when navigating links with keyboard arrows near links that creates ghost links in the editor we have tried to mitigate the problem by hiding these links.

Due to another bug UHF-9497 where pasting from word the ckeditor creates anchor links without attributes <a>, our previous solution hides text from the editor that's visible in the resulting page.

What was done

  • The css selector targeting the editor-only ghost links was made more specific to target only links that have attributes that create visible artifacts like external link arrows, tel and mailto links, button styles etc.
    • This should reduce the problems caused by the two problems colliding.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_ckeditor_hiding_anchors_from_word
  • Run make drush-cr

How to test

  • Check that pasting from the word file in the UHF-9497 no longer hides text.
  • Check that navigating left of a button link with left keyboard arrow still does not produce visual glitches
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants