Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X cookie compliance focus ring fix #842

Merged
merged 3 commits into from
Nov 30, 2023
Merged

UHF-X cookie compliance focus ring fix #842

merged 3 commits into from
Nov 30, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Nov 30, 2023 •
edited by khalima
Loading

UHF-X

image

What was done

  • Z-index was finetuned to make sure that the focus-ring is visible
  • Latest caniuse-lite was added

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_cookie_compliance_focus_ring_fix
  • Run make drush-cr

How to test

  • Check that cookie page focus ring works again
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

khalima
khalima approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purrrfect! Thanks for this! 🚀

@Arkkimaagi Arkkimaagi merged commit ea0978f into main Nov 30, 2023
1 check passed
@Arkkimaagi Arkkimaagi deleted the UHF-X_cookie_compliance_focus_ring_fix branch November 30, 2023 06:52
This was referenced Nov 30, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Arkkimaagi Arkkimaagi mentioned this pull request Dec 5, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkkimaagi @khalima