Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9354 Node packages #835

Merged
merged 9 commits into from
Nov 24, 2023
Merged

UHF-9354 Node packages #835

merged 9 commits into from
Nov 24, 2023

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Nov 23, 2023 •
edited by teroelonen
Loading

UHF-9354

What was done

  • Updated svg-sprite to v3-beta3. As it is not available in npm, the github version was used instead.
  • Updated node packages which had vulnerabilities

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9354_node_packages
  • Run make drush-cr

How to test

  • As the whole architecture of svg-sprite library has been changed, check that the icons work as before.
    • Check that the icons work in front end
    • Check that the icons work in the admin theme
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@khalima khalima mentioned this pull request Nov 23, 2023
Merged
3 tasks
This was referenced Nov 23, 2023
Merged
Merged
This was referenced Nov 23, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
teroelonen
teroelonen approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 🦖

@khalima khalima merged commit dfc3be8 into main Nov 24, 2023
1 check passed
@khalima khalima deleted the UHF-9354_node_packages branch November 24, 2023 12:31
This was referenced Nov 24, 2023
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 24, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen