Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9298: Fixed other info accordion bug in tpr units #823

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Nov 10, 2023

UHF-9298

Other info accordion is displayed on TPR units even if it doesn't have any content.
Example: https://www.hel.fi/fi/sosiaali-ja-terveyspalvelut/terveydenhoito/sairaalat-ja-poliklinikat/laakson-sairaala.

What was done

  • Moved the accordion rendering to be inside the if statement.
  • Fixed indenting.

How to install

  • Make sure your SOTE instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9298_other-info-accordion-bug
  • Run make drush-cr

How to test

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix, works on my machine. Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants