Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8815: Lang attribute for job search results #821

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

xkhaven
Copy link
Contributor

@xkhaven xkhaven commented Nov 7, 2023

UHF-8815

What was done

  • Added lang attribute for job result fields when result language differs selected site language

How to install

How to test

  • New attribute lang is set to all fields on job search results which content is not the same as active site language
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@juho-lehmonen juho-lehmonen self-requested a review November 9, 2023 07:08
Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue found with the heading element, otherwise works as intended.

src/js/react/common/Card.tsx Outdated Show resolved Hide resolved
@xkhaven xkhaven requested a review from juho-lehmonen November 9, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants