Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9126 fix false positives #809

Merged
merged 3 commits into from
Oct 24, 2023
Merged

UHF-9126 fix false positives #809

merged 3 commits into from
Oct 24, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Oct 24, 2023

UHF-9126

The visual regression tests failed even though nothing had really changed.

What was done

  • Removed the iframes, since it doesn't make sense to test external content.
  • Fixed the selector of announcements.
  • Tweaked the testing of the text component, earlier only the first heading was tested and it wasn't so useful in my opinion.

How to install

  • Make sure your platform test instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9126_fix-false-positives
  • Run make drush-cr

How to run the tests

Run these commands inside the HDBT theme root.

How to test

  • Check that no tests fail if no changes were made.
  • Check that code follows our standards

Note: There is a problem currently with TPR units. I created a separate ticket for that.

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works now on the parts that it promised to work 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants