Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8685: Photographer information for the liftup with image paragraph #791

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Oct 4, 2023

UHF-8685

What was done

  • Added the photographer information visible for the Liftup with image paragraph.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8685
  • Run make drush-cr

How to test

  • Create a landing page with all the variations of the liftup with image with images with and without the photographer information. There is going to be altogether 12 different variations. I don't know if you need to test the secondary color variations if you test the primary color variations but I will leave this up to you :)
  • Mobile & Desktop: Make sure that on the variations that have the background image the photographer information is always aligned left and under the image.
  • Mobile: Make sure that on the variations that have overlapping image and text-box the caption is aligned to right and located on the top.
  • Desktop: Make sure that on the variations that have overlapping image and text-box the caption is aligned left if the image is aligned left or right if the image is aligned on the right and that it is located under the picture on desktop.
  • Double check all the breakpoints that the captions move to correct places nicely.
  • Check that code follows our standards.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

@Jussiles Jussiles self-requested a review October 9, 2023 12:04
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 🦜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants