Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X: Hide empty title from service channel TPR content #782

Merged
merged 1 commit into from
Nov 2, 2023
Merged

UHF-X: Hide empty title from service channel TPR content #782

merged 1 commit into from
Nov 2, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Sep 26, 2023 •
edited by dire
Loading

UHF-X

We have empty headings in a minor amount of content

What was done

  • A check was added to avoid creating empty headings

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh on kymp instance
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_service_channel_empty_title
  • Run make drush-cr

How to test

  • Check that empty content no longer appears on kymp page
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@dire dire self-requested a review November 2, 2023 11:23
@Arkkimaagi Arkkimaagi merged commit 540dbfa into main Nov 2, 2023
@Arkkimaagi Arkkimaagi deleted the UHF-X_service_channel_empty_title branch November 2, 2023 11:48
This was referenced Nov 9, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dire dire dire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkkimaagi @dire