Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8211: Common error message for react searches #768

Merged
merged 9 commits into from
Sep 14, 2023

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Sep 13, 2023

UHF-8211

What was done

  • Update common error message
  • Add common error component to linkedevents and school search
  • Refactor LoadingSpinner to use common loading spinner component
  • Cleaning

How to install

How to test

  • Create a page with School search and check that the search is working
  • Go to the root of Kasko project and run docker stop helfi-kasko-elastic to stop Elastic
  • Refresh the page you created
  • Check that School search error message is looking good and it's translated
  • Check that loading spinner looks good. From Chromes network tab you can mock Fast 3G or Slow 3G connection to see the loading spinner
  • Check that code follows our standards

@dire dire self-requested a review September 14, 2023 10:11
Copy link
Contributor

@dire dire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Translations didn't work for me for reason x, but they shouldn't break because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants