Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X: update postcss-preset-env package and move it to devDependencies. #745

Merged
merged 1 commit into from
Aug 15, 2023
Merged

UHF-X: update postcss-preset-env package and move it to devDependencies. #745

merged 1 commit into from
Aug 15, 2023

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Aug 15, 2023 •
edited by teroelonen
Loading

What was done

  • Update postcss-preset-env package manually and move it to devDependencies

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X-update-postcss-preset-env-package
  • Run make drush-cr

How to test

  • Check that site and styles still work
  • Check that developing, building and linting HDBT still works
  • Check that code follows our standards

teroelonen
teroelonen approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and theme works well after change 🦖

@Jussiles Jussiles merged commit 87dbb9a into main Aug 15, 2023
@Jussiles Jussiles deleted the UHF-X-update-postcss-preset-env-package branch August 15, 2023 13:01
This was referenced Aug 24, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jussiles @teroelonen