Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X: Update Typescript version #740

Merged
merged 8 commits into from
Aug 28, 2023
Merged

UHF-X: Update Typescript version #740

merged 8 commits into from
Aug 28, 2023

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Aug 14, 2023 •
edited
Loading

What was done

  • Update Typescript version
  • Fix type error in job search
  • Clean unused imports from job search

How to install

  • Make sure Rekry instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X-update-typescipt-version
  • Run make drush-cr

How to test

  • Check job search work normally
  • Check that there are no type errors
  • Check that building job search app works
  • Check that code follows our standards

@Jussiles Jussiles requested a review from jeremysteerio August 14, 2023 10:51
@Jussiles Jussiles changed the title UHF-X: update typescript version UHF-X: Update Typescript version Aug 15, 2023
jeremysteerio
jeremysteerio reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jeremysteerio jeremysteerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Prolly better if this on gets squashed / dropped to maintain better history

image
Nothing really points to this in the source, I suspect the built version contains some leftover testing stuff

Other than these, job search seems to be working allright 👍

@Jussiles Jussiles merged commit 9067b6e into main Aug 28, 2023
@Jussiles Jussiles deleted the UHF-X-update-typescipt-version branch August 28, 2023 13:26
This was referenced Aug 29, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
khalima pushed a commit that referenced this pull request Oct 23, 2023
@Jussiles @khalima
UHF-X: Update Typescript version (#740)
03d0af8 
* test

* UHF-X: update typescript version

* UHF-X: fix type error and clean unused imports.

* Add react dists

* Clean tests from Card.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremysteerio jeremysteerio jeremysteerio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jussiles @jeremysteerio