UHF-3810 TODOs

[teroelonen]

UHF-3810

What was done

• Went through all the TODOs in the HDBT-theme and created tickets of the ones that didn't have.
• Removed some old code that was found when checking the TODOs.

How to install

• Make sure your instance is up and running on latest dev branch.
  • git pull origin dev
  • make fresh
• Update the HDBT theme
  • composer require drupal/hdbt:dev-UHF-3810_todos
• Run make drush-cr

How to test

• Check the TODOs make sense and are written in similar format to help when searching them.
• Check that the service page with service units listed on the bottom works fine if you add some paragraphs to the lower content.
• Check that the unit page with accessibility information accordion on the bottom works fine if you add some paragraphs to the lower content.
• Check that if you add <nolink> link to main menu first level it doesn't break to layout like it did before.
• Check that the map paragraph and external video paragraph and image-placeholder still work correctly after the aspect-ratio code change. You can for example add them to a standard page and scale the page to make sure they still scale nicely.
• Check that code follows our standards

Designers review

• This PR does not need designers review
• This PR has been visually reviewed by a designer (Name of the designer)

[Arkkimaagi]

Looks good, but I found a couple little questions..

[Arkkimaagi]

Approved, but github mobile has hidden the approve action too well 🙈