UHF-8590: Search accessibility fix

[xkhaven]

UHF-8590

What was done

• Fixed "Clear all selections" label to field precise
• Fixed Job Search Type of employment relationship field's label for attribute to point proper input
• Fixed focus to the results title area on "No results" case on those forms which had focus to results count functionality
• Fixed "Clear all" button's aria-hidden attribute
• Fixed margin on filter pills buttons

How to install

• Read carefully the test instructions for all instances listed below and do the following install on each
• Make sure your instance is up and running on latest dev branch.
  • git pull origin dev
  • make fresh
• Update the HDBT theme
  • composer require drupal/hdbt:dev-UHF-8590_Search_accessibility_fix
• Run make drush-cr

How to test

Test steps for all instances unless exceptions mentioned separately

• Clearing all field values button has screen reader label describing the field's label instead of common "Clear all" text
• Clicking label focuses on proper input field
• When clicking search submit button, the focus is set to search results count
• When "Clear all selections" button is visible it has attribute aria-hidden set to false and when not visible, vice versa
• Filter clear buttons has no margin on the icon (X)
• Check that code follows our standards

Instances with affected forms to test

• Front page
  • Checkout the local branch, see Other PR's
    • git checkout UHF-8590_Search_accessibility_fix
    • make fresh
    • make drush-cr
  • Open News archive (https://helfi-etusivu.docker.so/fi/uutiset)
• Rekry
  • Open Job Search (https://helfi-rekry.docker.so/fi/avoimet-tyopaikat/etsi-avoimia-tyopaikkoja)
• Kymp
  • Open Districts and Projects search (https://helfi-kymp.docker.so/fi/kaupunkiymparisto-ja-liikenne/kaupunkisuunnittelu-ja-rakentaminen/hae-suunnitelmia-ja-hankkeita)
• Kasko
  • Create new Landing Page with School Search paragraph
• Sote
  • Open Events search (https://helfi-sote.docker.so/fi/sosiaali-ja-terveyspalvelut/senioripalvelut/palvelukeskukset)

Designers review

• This PR does not need designers review

[Jussiles]

Mostly works nicely 👍

I added one question about using !important

I found some things that aren't working as intended yet:

• Event search focus to search results is not working
• School and news search "Clear selections" buttons have wrong area-hidden values:

[Jussiles]

It's good now! Event search fix will done in other PR.