Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Add better checking for empty title and description fields in components #701

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Jun 29, 2023

UHF-X

There are some pages where editors have entered a single space-character or a non-breaking space to optional fields in components. This causes layout and accessibility problems as our code did not catch these edgecases.

What was done

  • Common component title and description are now checked for space characters and non-breaking spaces.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_handle_empty_component_fields_better
  • Run make drush-cr

How to test

  • Check that adding space or   (on macos use alt+space) does not cause title or description html to appear in components.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@Jussiles Jussiles self-requested a review June 29, 2023 11:11
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wörks! 🦜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants