Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8532: Map accessibility improvements #692

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jun 19, 2023

UHF-8532

What was done

  • Moved skip-links to be added with cookie compliance functionality javascript so that they are not available unless you have agreed to cookies.
  • Changed the larger map link alignment to left.
  • Appended the iframe title to the larger map link.

How to install

  • If you have dump.sql that is older than few days I would suggest you to remove that one first.
  • Make sure your instance is up and running on latest dev branch. Check with instance that has TPR enabled since we need to unit maps as well.
    • git pull origin dev
    • make fresh (this will get you a new db from the testing server)
  • Update the helfi_platform_config module
    • composer require drupal/helfi_platform_config:dev-UHF-8532_map_accessibility_improvements
  • Update the hdbt theme
    • composer require drupal/hdbt:dev-UHF-8532_map_accessibility_improvements
  • Run make drush-updb drush-cr
  • If you want to check that the translations work you and also run the drush locale:check; drush locale:update; drush cr in the shell.

How to test

  • Since the helfi_platform_config changes will reimport the configuration from the install folder there can be some instances like SOTE and KASKO where we need to revert some of the changes that the update hook does. These PRs however ignore those at this point and they are fixed in the automatic update PRs after merging these branches.
  • Go to add a map paragraph to any existing content or create a new one.
  • Check that the link after the map is now aligned to left and has text in the following format: [IFRAME_TITLE] - Open larger map. Also make sure it doesn't open the link in a new tab anymore.
  • Check also that you still have the Skip map links for screen readers before and after the map if you have accepted cookies.
  • Check that if you haven't accepted the cookies there is also no Skip map links available.
  • Next go check any TPR-unit page that has map in it. The same things as above should apply to this map as well. The [IFRAME_TITLE] is hardcoded tho.
  • Check that code follows our standards.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@xkhaven xkhaven self-requested a review June 20, 2023 10:36
Copy link
Contributor

@xkhaven xkhaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described and looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants