Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8673: Fix Metro button contrast #691

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

xkhaven
Copy link
Contributor

@xkhaven xkhaven commented Jun 19, 2023

UHF-8673

What was done

  • Metro color theme had wrong contrast on buttons

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8673_Fix_Metro_button_contrast
  • Run make drush-cr

How to test

  • Banner with a link using style of "Full colour background" has black background and white text, hover has transparent background and black text
  • Banner with a link using style of "Only borders" has transparent background, black borders and black text, hover has black background and white text
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants