Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-3511: Add user-edited-content class to wrap custom html #685

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Jun 8, 2023

UHF-3511

Add user-edited-content class to wrap custom html.

What was done

  • Add user-edited-content class to templates where custom (editor-written or imported) html is displayed
  • Add styles for the class

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-3511-user-edited-content-class
  • Run make drush-cr

How to test

  • Add landing page or standard page
    • Add some paragraphs to it you know contain custom HTML fields (long text fields with ckeditor)
    • Inspect the page where the custom HTML is, it should be wrapped with user-edited-content
  • Read code, can you think of any other places where there is custom HTML?

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and harmless, approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants