Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8519: Fixed the map embed URL. #673

Merged
merged 1 commit into from
May 29, 2023
Merged

UHF-8519: Fixed the map embed URL. #673

merged 1 commit into from
May 29, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented May 26, 2023

UHF-8519

The map component twig template is using wrong version of the map URL.

What was done

  • Fixed the template to use correct URL variable, which is provided by code that makes sure that the map URL gets the /embed to the URL.

How to install

  • Make sure your Kasko instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8519_map-embed-url-fix
  • Run make drush-cr

How to test

Designers review

  • This PR does not need designers review

Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was way simpler than I thought it could be. Good job! Approved! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants