Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8451: Calculator accessibility updates #662

Merged
merged 4 commits into from
May 26, 2023
Merged

UHF-8451: Calculator accessibility updates #662

merged 4 commits into from
May 26, 2023

Conversation

xkhaven
Copy link
Contributor

@xkhaven xkhaven commented May 12, 2023 •
edited by teroelonen
Loading

UHF-8451

Accessibility issues on calculator form response.

  • The receipt heading is supposed to be focused and scrolled into view when the result is calculated
  • Child details should be in fieldset/legend context so that they're explained to screen reader user properly

What was done

  • Added scroll focus to receipt
  • Added fieldset/legend support to forms and integrated it with dynamic_slot feature in Kasko calculator

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8451_Calculator_accessibility
  • Run make drush-cr

How to test

  • When calculation is done, page should scroll to result section
  • Check that children are in fieldset that has legend-element as the heading of the area
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@xkhaven xkhaven changed the title UHF-8451: Calculator scroll focus to receipt UHF-8451: Calculator accessibility updates May 15, 2023
@Arkkimaagi Arkkimaagi force-pushed the UHF-8451_Calculator_accessibility branch from 5e14718 to 557e611 Compare May 25, 2023 11:00
@Arkkimaagi Arkkimaagi marked this pull request as ready for review May 25, 2023 11:02
teroelonen
teroelonen approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works good 🦖

@Arkkimaagi Arkkimaagi merged commit 59de565 into main May 26, 2023
@Arkkimaagi Arkkimaagi deleted the UHF-8451_Calculator_accessibility branch May 26, 2023 05:59
This was referenced May 26, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xkhaven @teroelonen @Arkkimaagi