Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8200: Glob 9.x update #579

Merged
merged 2 commits into from
Mar 13, 2023
Merged

UHF-8200: Glob 9.x update #579

merged 2 commits into from
Mar 13, 2023

Conversation

xkhaven
Copy link
Contributor

@xkhaven xkhaven commented Mar 13, 2023 •
edited by jira bot
Loading

UHF-8200

What was done

  • Dependency Glob has been updated to version 9.x
  • Webpack changes to implement new globSync function
  • Changed function globSync does not return current path, so added it to modules entry filepath

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8200_glob-9.x_update
  • Run make drush-cr

How to test

  • Check that rebuild files still works
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

Other PRs

@Jussiles Jussiles self-requested a review March 13, 2023 08:36
Jussiles
Jussiles approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xkhaven xkhaven merged commit 1b79cab into main Mar 13, 2023
@xkhaven xkhaven deleted the UHF-8200_glob-9.x_update branch March 13, 2023 13:10
This was referenced Mar 17, 2023
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jussiles Jussiles Jussiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xkhaven @Jussiles