-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOM-266 Profile block #523
Conversation
…tyles to support profile item on the header
…ctionality to profile block functionality
62c5ace
to
3c7643b
Compare
…ggle functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job, such a complex deprecated code mess that you cleaned. I have no idea how you had the patience. I did spot a bunch of stuff, but otherwise great stuff! 🌹
…poses around page.messages, added commenting on menu.js changes
…oggle-button.twig to avoid css nesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job cleaning stuff, I happened to stumble upon a couple of minor things still. Sorry! 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Approved 🌻
LOM-266
What was done
How to install
git pull origin dev
make fresh
composer require drupal/hdbt:dev-LOM-266_profile_block
composer require drupal/helfi_platform_config:dev-LOM-266_profile_block
make shell
drush en helfi_profile_block
drush locale:check; drush locale:update; drush cr
/admin/structure/block
and add the Profile block to the Header - Branding region as the last block, hide its title and save the configuration.How to test
Designers review
Other PRs