Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X: Fix TPR-unit wide teaser heading level #521

Merged
merged 1 commit into from
Jan 16, 2023
Merged

UHF-X: Fix TPR-unit wide teaser heading level #521

merged 1 commit into from
Jan 16, 2023

Conversation

Arkkimaagi
Copy link
Contributor

UHF-X

TPR-unit wide teaser has heading level <h3> even when it's it's on a page with no <h2> on it.

What was done

  • Heading level was set to H2

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_tpr_unit_wide_teaser_heading_level
  • Run make drush-cr

How to test

  • Check that heading level is H2 for "Sisältönosto" components
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@dire dire self-requested a review January 13, 2023 11:06
@Arkkimaagi Arkkimaagi merged commit 13fbc7a into main Jan 16, 2023
@Arkkimaagi Arkkimaagi deleted the UHF-X_tpr_unit_wide_teaser_heading_level branch January 16, 2023 07:18
This was referenced Jan 16, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dire dire dire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkkimaagi @dire