Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-7609 global nav inject #514

Merged
merged 3 commits into from
Jan 13, 2023
Merged

UHF-7609 global nav inject #514

merged 3 commits into from
Jan 13, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Jan 12, 2023

UHF-7609

Global navigation needs a version where instance data is not pushed to global nav, but is injected instead. The toggle for this will be if global nav api keys are entered or not. If they're not entered, the inject method will be used. The background part of this is handled in: City-of-Helsinki/drupal-module-helfi-navigation#22

This PR only handles the color change of injected elements as instructed by the design spec

image

What was done

  • Black-5 background color was added to main level of injected content in mobile navigation.
  • When json api url does not work, the fallback was broken, it was fixed here as well.

How to install

  • Make sure your REKRY instance is up and running on latest dev branch. And no global nav keys have been added.
    • git pull origin dev
    • make fresh
  • Follow instructions in global nav PR to get it working
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-7609_global_nav_inject
  • Run make drush-cr

How to test

  • Check that Rekry main level has correct background color in js nav like in the design specs.
  • Check that code follows our standards

Designers review

  • This PR has been visually reviewed by a designer (Sami)

Other PRs

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants