Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X Fixed login screen layout if there is more than one tunnistamo-… #505

Merged
merged 1 commit into from
Dec 19, 2022
Merged

UHF-X Fixed login screen layout if there is more than one tunnistamo-… #505

merged 1 commit into from
Dec 19, 2022

Conversation

teroelonen
Copy link
Contributor

…login button

Fix login screen layout if there is more than one Tunnistamo login button.

What was done

  • Added spacing between the two buttons.

How to install

  • Make sure your form tools instance is running latest dev.
    • git checkout origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_multiple_tunnistamo_logins_layout_fix
  • Run make drush-cr

How to test

  • Go to the login page and there should now be 16px space between the two tunnistamo login buttons.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@teroelonen teroelonen merged commit fd9c487 into main Dec 19, 2022
@teroelonen teroelonen deleted the UHF-X_multiple_tunnistamo_logins_layout_fix branch December 19, 2022 07:23
This was referenced Dec 19, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima