Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Phasing component visual bug #500

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Dec 5, 2022

UHF-X Phasing component visual bug

As this slack thread mentions, the phasing component has a visual bug on a page as seen below.

image

What was done

  • A stupid bug was fixed on a css custom property where units of the line-height were missing.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_phasing_component_bug
  • Run make drush-cr

How to test

  • Add or visit a page with the phasing component
  • Check that the visual bug is fixed on this branch (it's broken in hdbt 4.3.4)
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@Arkkimaagi Arkkimaagi marked this pull request as ready for review December 5, 2022 09:24
@Jussiles Jussiles self-requested a review December 5, 2022 12:27
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants