Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-6857: Changed react and share margin to be with only js #493

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

lonkaanna
Copy link
Contributor

@lonkaanna lonkaanna commented Nov 25, 2022

UHF-6857

What was done

  • Changed react and share negative top margin to only work when js is enabled

How to install

Test i.ex. in sotes instance

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-6857-react-and-share-margin-fix
  • Run make drush-cr

How to test

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

@lonkaanna lonkaanna force-pushed the UHF-6857-react-and-share-margin-fix branch from 7b8cc86 to 43a8112 Compare November 29, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants