Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-4571: Hel.fi favicons #432

Merged
merged 9 commits into from
Nov 16, 2022
Merged

UHF-4571: Hel.fi favicons #432

merged 9 commits into from
Nov 16, 2022

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Oct 6, 2022

UHF-4571

Current favicons are transparent and cause problems with dark browser skins. They do not behave well with all use-cases as some files are missing. This updates favicons to proper format.

What was done

  • Added relevant favicon files
    • And updated them to latest HDS favicons
  • Added source files
    • HDS handles these on their end
  • Added instructions on how to create files from source files and documentation on how to use said files
    • HDS handles these on their end
  • Added html code to use the files

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-4571_favicons
  • Run make drush-updb drush-cr

How to test

  • Check that favicons work in all contexts that you can think of
  • Check that favicon follows HDS guideline in using dark version in dark mode (where svg is supported)
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

@Arkkimaagi Arkkimaagi marked this pull request as ready for review October 6, 2022 19:13
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical implementation works perfectly 🦖

@Arkkimaagi Arkkimaagi marked this pull request as draft October 10, 2022 09:46
@Arkkimaagi
Copy link
Contributor Author

I'll discuss about the wanted design with Mari K before we proceed with this.

@Arkkimaagi
Copy link
Contributor Author

Arkkimaagi commented Nov 16, 2022

Updated latest HDS favicons to this PR that were generated due to the discussions started by this PR

@Arkkimaagi Arkkimaagi marked this pull request as ready for review November 16, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants