Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9357: Remove HDS-dropdown quickfix now that it has been fixed in HDS #1156

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 10, 2025

UHF-9357

What was done

  • Removed HDS-dropdown quickfix now that it has been fixed in HDS

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9357
  • Run make drush-cr

How to test

  • You need to check React filter searches with dropdowns. The thing to check is that the dropdown button with class such as Select-module_button__* Select-module_placeholder__* now doesn't have the background-color: inherit; set from our css anymore but instead on the styles coming from the React-component. You can for example compare the production and local versions of the button css and you should see the difference.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1156/html_report/

Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants