Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X: Change postcss processing so that logical properties are preserved #1149

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 9, 2025

UHF-X

What was done

  • Change postcss processing so that the CSS logical properties such as padding-inline are preserved and not converted.

How to install

  • Make sure your instance is up and running on latest dev branch. Good one to use for testing is etusivu-instance.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_css_logical_properties_fix
  • Run make drush-cr

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

Copy link

github-actions bot commented Jan 9, 2025

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1149/html_report/

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good one! 🚀

@teroelonen teroelonen merged commit 46c6f98 into main Jan 9, 2025
3 checks passed
@teroelonen teroelonen deleted the UHF-X_css_logical_properties_fix branch January 9, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants