Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch in case of external route with no route parameters #1144

Merged
merged 2 commits into from
Dec 20, 2024
Merged

catch in case of external route with no route parameters #1144

merged 2 commits into from
Dec 20, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Dec 20, 2024 •
edited
Loading

Caused whitescreen on a page with sidebar

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1144/html_report/

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1144/html_report/

@rpnykanen rpnykanen merged commit 2b18785 into main Dec 20, 2024
2 checks passed
@rpnykanen rpnykanen deleted the UHF-X_url_getrouteparams_exception branch December 20, 2024 11:24
This was referenced Dec 20, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyrsky hyrsky hyrsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpnykanen @hyrsky